improve SaR snapshot UI behavior#3595
Merged
georgweiss merged 1 commit intoOct 22, 2025
Merged
Conversation
Member
+1 thank you... such a simple but impactful change |
6 tasks
georgweiss
approved these changes
Oct 20, 2025
georgweiss
left a comment
georgweiss
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, but found a bug when testing this.
#3597 fixes the bug and maybe this PR should pull that in.
Member
|
@georgweiss I have merged the node setting PR... can I merge this and then we can test it again or do you th ink it is safer to update this branch with master and test again |
Collaborator
|
@shroffk, looks good, I merged it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically, the SaR snapshot controller was a bit unintuitive. The UI suggested you needed to enter a name / description before hitting take snapshot / save, but hitting take snapshot would clear out the metadata entered by the user. I changed it so that the name and the comment are no longer cleared. However, if you start from an existing snapshot, this would preserve the name / description from that existing snapshot (which would be fine IMO, you can start editing from there) but the name needs to be unique. The error message shown to the user on a non-unique node name contained exception names because it was a nested exception. This is no longer the case.
Checklist
Testing: Tested new behavior locally
Documentation: I don't think this is significant enough to warrent a release not entry, nor is it breaking